feat: support multiple external VPN peering gateways #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doniz
changed the title
|
@imrannayer can I get approval? |
|
/gcbrun |
|
Hi @imrannayer, I added an example and I wonder about creating in GCP 2 additional VPNs to reproduce 2 On-Premise DCs, but this needs a lot more time investment by creating external IPs. I think it's doable, but it becomes the same as Let me know if that's good enough. |
|
/gcbrun |
imrannayer
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
we would like to add this feature because we see that we could have many VPN peering gateways on selected tunnels in the GCP console without any issue, but this Terraform module does not support that.
In our case, we have an HA VPN that is connected to 2 on-premise DCs and instead of creating a new VPN instance, we may create a new tunnel that is linked to the specific peering gateway.
First, I thought to redo the variable of
peer_external_gatewayto setlist(object..., but I realized it became very complicated from Terraform's point of view. So I added an optional elementpeer_external_gateway_self_linkin the tunnels list object, so we could pass a custom resourceself_linkand setvar.peer_external_gatewaytonullto prevent creating resource inside of the module.Feedback is welcome.
Thank you, Donatas